Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populates vomnibar input with url ( Issue #2464) #2914

Closed
wants to merge 1 commit into from

Conversation

Gu1nness
Copy link

When is pressed, if the suggestion is a bookmark or history,
populates the input with the corresponding url.

Refers and solve #2464

@smblott-github
Copy link
Collaborator

Thanks, @Gu1nness.

This is quite a big change to the usability of the Vomnibar. There are use cases where this is the right thing to do, and probably others where it is not.

A (less discover-able) alternative might be to use <Control-Enter> to copy the currently-selected URL to the input.

Bottom line... I'm not sure.


Separately...

  1. If the URL inserted into the input is too long for the input, then we probably should put the focus at the end.
  2. What does it mean to do this in tabs mode (T)?
  3. There's something very broken in tabs mode and in bookmarks mode (b). Selecting an entry and editing the input, you'll see.

@Gu1nness
Copy link
Author

Gu1nness commented Feb 8, 2018

Indeed, I had missed these points (actually I didn't even know that this exists).
I'll look into it so this can be patched.
I agree for the <Control-Enter> this way it won't break the workflow the users.

@Gu1nness
Copy link
Author

Hi @smblott-github ,
I eventually pushed a new version, with .

@Gu1nness
Copy link
Author

I have corrected the small typo that I had mistakenly inserted.

philc added a commit that referenced this pull request Jan 10, 2020
philc added a commit that referenced this pull request Jan 10, 2020
@philc
Copy link
Owner

philc commented Jan 10, 2020

I wasn't able to merge this PR directly due to conflicts, but pushed your change in 2268e49. I hadn't realized I've been missing this all these years. Thank you @Gu1nness !

@philc philc closed this Jan 10, 2020
@philc
Copy link
Owner

philc commented Jan 10, 2020

I wish this was easier to discover. It would be cool to somehow have an opt-in cheat sheet built into Vomnibar, in the same spirit as typing "?" in Vimium. For now, I've documented this feature on this wiki page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants